Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
|
For reviewers/releasers: all of the cases at #55305 lead to failure states, therefore this should not be a major change. |
mcollina
reviewed
Mar 12, 2026
| } else if (isIterable(stream) || isReadableNodeStream(stream) || isTransformStream(stream)) { | ||
| ret = stream; | ||
| } else { | ||
| ret = Duplex.from(stream); |
Contributor
Author
There was a problem hiding this comment.
As far as I see by validating and throwing early this becomes dead code. This is the branch for the "source stream" and the only case this was being used was a non-readable node stream which will now throw
| } | ||
| ret = stream; | ||
| } else { | ||
| ret = Duplex.from(stream); |
Contributor
Author
There was a problem hiding this comment.
Similar to above, unless I'm missing something with the early validation this becomes dead code. I'm less confident on this one though 😅
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62214 +/- ##
==========================================
+ Coverage 89.65% 89.68% +0.02%
==========================================
Files 676 676
Lines 206578 206639 +61
Branches 39562 39581 +19
==========================================
+ Hits 185216 185329 +113
+ Misses 13475 13446 -29
+ Partials 7887 7864 -23
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #55305
I still need to add the teststests are added, but I'd appreciate some early feedback on the approach.